search

facebookresearch / nocturne

A data-driven, fast driving simulator for multi-agent coordination under partial observability.
MIT License
259 stars 29 forks source link

[Bug] Mistake in continuous action space definition #56

Closed roggirg closed 1 year ago

roggirg commented 1 year ago

Operating system

Ubuntu 20.04

Bug description

There seems to be a (small) mistake in the code here: https://github.com/facebookresearch/nocturne/blob/94fc821abb9a9c30f693614f96e36c9f4b83a544/nocturne/envs/base_env.py#L103

The high values should use the key 'x_upper_bound' instead of 'x_lower_bound'.

Steps to reproduce

No response

Relevant log output

No response

eugenevinitsky commented 1 year ago

Omg, that explains why continuous actions never worked. Great catch!

eugenevinitsky commented 1 year ago

@roggirg Thanks again for catching the remaining lower->upper!!