Prevent pip from installing old version of lightning

facebookresearch / nougat

Implementation of Nougat Neural Optical Understanding for Academic Documents

https://facebookresearch.github.io/nougat/

MIT License

8.81k stars 561 forks source link

Prevent pip from installing old version of lightning #103

Closed osyvokon closed 1 year ago

osyvokon commented 1 year ago

This fix makes sure that nougat installs lightning 2.x.x and not lightning 2022.10.25 which is older that 2.x.x

lightning used to use year.mm.dd versioning scheme before they switched to the standard semantic versioning. Without this fix, lightning>=2.0.0 matched 2022.10.25 which is older than 2.x.x. This leads to a deprecation warning or broken installation (depending on the python/pip versions) due to the bug in older lightning versions.

lukas-blecher commented 1 year ago

Wow that's stupid. They should have incremented to 3