search

facebookresearch / nougat

Implementation of Nougat Neural Optical Understanding for Academic Documents
https://facebookresearch.github.io/nougat/
MIT License
8.98k stars 567 forks source link

Added mention of minimum Python requirement #109

Closed sidharthrajaram closed 1 year ago

sidharthrajaram commented 1 year ago

rasterize.py features union types in type hints which was only introduced as a feature in Python 3.10 (you get a TypeError when running on previous Python versions). Figured it would be cool to explicitly mention this requirement before installation instructions.

facebook-github-bot commented 1 year ago

Hi @sidharthrajaram!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

facebook-github-bot commented 1 year ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

lukas-blecher commented 1 year ago

3.9 is still supported in 2e8dfccdb0a86c190e70bebafe2806dc5929d956 (actually it was only not supported in the commit previous to that)