facebookresearch / ocean

Ocean is the in-house framework for Computer Vision (CV) and Augmented Reality (AR) applications at Meta. It is platform independent and is mainly implemented in C/C++.
https://facebookresearch.github.io/ocean/
MIT License
614 stars 54 forks source link

[cmake] Disable deprecation warning in iOS builds #25

Closed enpe closed 1 month ago

enpe commented 1 month ago

This change silences compiler warnings about the deprecation of the OpenGL API on iOS. The warning are similar to this:

.../ocean/impl/ocean/rendering/glescenegraph/GLESShaderProgram.h:448:28: 'glGetUniformLocation' is deprecated: first deprecated in iOS 12.0 - OpenGLES API deprecated. (Define GLES_SILENCE_DEPRECATION to silence these warnings)

Test plan:

Follow the instructions for building iOS apps with XCode and repeat this for the following apps:

Observe that there are no longer any deprecation warnings about OpenGL.

facebook-github-bot commented 1 month ago

@thorntondr has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 1 month ago

@thorntondr merged this pull request in facebookresearch/ocean@41c889b6762d036ab4fdf3cfbcb3559f34ef869a.