search

facebookresearch / optimizers

For optimization algorithm research and development.
Other
442 stars 31 forks source link

Fix imports for DDP example in README.md #18

Closed G-structure closed 2 months ago

G-structure commented 2 months ago

In the DDP example, DDPShampooConfig is using enum CommunicationDType which needs to be imported from distributed_shampoo.shampoo_types

facebook-github-bot commented 2 months ago

Hi @cyber-phys!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

facebook-github-bot commented 2 months ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

G-structure commented 2 months ago

Closed this since changes were included in commit: d745e0a2c23709679425b667fdebd69337202ba8