search

facebookresearch / optimizers

For optimization algorithm research and development.
Other
442 stars 31 forks source link

Avoid using local modules in some unittests #49

Closed runame closed 1 day ago

runame commented 2 days ago

To avoid installation issues like #46, I added the Python -I flag when running two of the unittests.

Note that the unittests for which I didn't add this flag import from the distributed_shampoo.tests directory that is not installed as part of the package, so trying to run these tests with the -I flag will lead to an import error.

tsunghsienlee commented 1 day ago

Thanks @SeunghyunSEO for reporting this again, and @runame for proposing this solution.

facebook-github-bot commented 1 day ago

@tsunghsienlee has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 1 day ago

@tsunghsienlee merged this pull request in facebookresearch/optimizers@03d7e13dabfbe0c90648e1bd9dada7ea637e6013.