Closed raedle closed 1 year ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
This pull request was exported from Phabricator. Differential Revision: D42060942
This pull request has been merged in facebookresearch/playtorch@c93ec9324141d7293e5f6c2d47db27bf32f9acee.
Summary: The Hermes GC will eventually clean up orphan host objects. This is also the case for
AudioHostObject
, which itself has a reference toAudio
that needs to be cleaned up, hence the call to theAudio::~Audio
destructor. On Android, it will try to release theglobal_ref<JAudio>
resource, which at the time, may not run in the JVM thread scope causing an app crash.Differential Revision: D42060942