search

facebookresearch / playtorch

PlayTorch is a framework for rapidly creating mobile AI experiences.
https://playtorch.dev/
MIT License
830 stars 101 forks source link

fix the splash screen warning #221

Closed liuyinglao closed 1 year ago

liuyinglao commented 1 year ago

Summary

The Android app is throwing a splash screen error at starting the app. This is fixing the error. (P791684209)

Unhandled promise rejection [Error: No native splash screen registered for provided activity. Please configure your application's main Activity to call 'SplashScreen.show' (https://github.com/expo/expo/tree/main/packages/expo-splash-screen#-configure-android).]

Reading that helps:

https://github.com/expo/expo/tree/main/packages/expo-splash-screen#-configure-androidmanifestxml https://docs.expo.dev/versions/latest/sdk/splash-screen/

Changelog

[Error] [Android] - Get rid of splash-screen error msg

Test Plan

yarn expo run:android and see error msg is gone

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **playtorch** | ⬜️ Ignored ([Inspect](https://vercel.com/fbopensource/playtorch/DqP26JV1v6sZHorXr7ZUQGDv7JVU)) | | | Jul 17, 2023 7:01am |
liuyinglao commented 1 year ago

@facebook-github-bot import

facebook-github-bot commented 1 year ago

@liuyinglao has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 1 year ago

@liuyinglao merged this pull request in facebookresearch/playtorch@f4ce3cde1c09d790d4b8d2db524584f113ad8759.