search

facebookresearch / playtorch

PlayTorch is a framework for rapidly creating mobile AI experiences.
https://playtorch.dev/
MIT License
830 stars 101 forks source link

Fix wrapObject typeFooDerivedFromBar then unwrapObject typeBar will cause error on iOS #229

Open flyskywhy opened 1 year ago

flyskywhy commented 1 year ago

Fix wrapObject typeFooDerivedFromBar then unwrapObject typeBar will cause error on iOS, e.g. image.getWidth() will be -1, or Error: react_native_pytorch_core.MediaToBlob.MediaToBlobError.unknownUnwrappedObject

Summary

the type in JSContext.wrapObject of photoOutput in CameraView.swift is Image the type in JSContextUtils.unwrapObject of getWidth in ImageModule.swift is IImage

Changelog

Test Plan

tested in RN0.64.3 with Xcode14.0.1(14A400) on macOS Monterey 12.6.5 (21G531), iOS 14.4.2 on iPhone7

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **playtorch** | ⬜️ Ignored ([Inspect](https://vercel.com/fbopensource/playtorch/4xEDiTnm7a8GFpjBKTi5riMG17tU)) | [Visit Preview](https://playtorch-git-fork-flyskywhy-main-fbopensource.vercel.app) | | Aug 31, 2023 2:18am |