facebookresearch / pytorch3d

PyTorch3D is FAIR's library of reusable components for deep learning with 3D data
https://pytorch3d.org/
Other
8.81k stars 1.32k forks source link

Use updated naming to remove warning #1687

Closed eclipse0922 closed 11 months ago

eclipse0922 commented 12 months ago

diag_suppress is deprecated from cuda

facebook-github-bot commented 12 months ago

Hi @eclipse0922!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

facebook-github-bot commented 12 months ago

@bottler has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 12 months ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

eclipse0922 commented 12 months ago

Linter changed 59 filest but not global.h.

bottler commented 12 months ago

Linter changed 59 filest but not global.h.

Don't worry about it. I suspect it's a Python thing, maybe with import ordering?

eclipse0922 commented 12 months ago

Linter changed 59 filest but not global.h.

Don't worry about it. I suspect it's a Python thing, maybe with import ordering?

Then, do I need to do something more for this PR?

bottler commented 12 months ago

Thanks for asking. No need to do anything more. It needs to be dealt with by us internally.

facebook-github-bot commented 11 months ago

@bottler merged this pull request in facebookresearch/pytorch3d@c373a84400328d9236226b6aef40bb2bde413cd0.

bottler commented 11 months ago

Thanks for fixing this!