search

facebookresearch / pytorch3d

PyTorch3D is FAIR's library of reusable components for deep learning with 3D data
https://pytorch3d.org/
Other
8.7k stars 1.3k forks source link

feat: changed = to == #1776

Closed ashimdahal closed 5 months ago

ashimdahal commented 5 months ago

The official pytorch's documentation follows the following notation with == instead of =.

https://pytorch.org/get-started/previous-versions/

consistency changes.

bottler commented 5 months ago

Is there are problem you think this solves? I could imagine for example that the user might want to get a patch version of pytorch-cuda. I think it's fine to leave this as is.

ashimdahal commented 5 months ago

Yeah. I proposed that because I was getting torch 2.12 installed instead of 1.13 but turns out it was a conda in hpc issue rather than the notation. Either way it’s just to keep consistency with pytorch.

Best Regards,

Ashim Dahal

Research Assistant

Department of Computer Science

The University of Southern Mississippi

@.***

(769) 969-5007

118 College Drive #6899

ashimdahal.com.np

https://ashimdahal.com.np

https://www.github.com/ashimdahal

https://www.linkedin.com/in/ashimdahal

The content of this email is confidential and intended for the recipient specified in message only. It is strictly forbidden to share any part of this message with any third party, without a written consent of the sender. If you received this message by mistake, please reply to this message and follow with its deletion, so that we can ensure such a mistake does not occur in the future.

On Mon, Apr 8, 2024 at 9:46 AM Jeremy Reizenstein @.***> wrote:

Is there are problem you think this solves? I could imagine for example that the user might want to get a patch version of pytorch-cuda. I think it's fine to leave this as is.

— Reply to this email directly, view it on GitHub https://github.com/facebookresearch/pytorch3d/pull/1776#issuecomment-2042952376, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKV3UNB4HLTSSQA7XWTETUTY4KUUPAVCNFSM6AAAAABF3TIB36VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBSHE2TEMZXGY . You are receiving this because you authored the thread.Message ID: @.***>

bottler commented 5 months ago

Let's leave this as is.

ashimdahal commented 5 months ago

Sounds good.

On Mon, Apr 8, 2024 at 12:26 PM Jeremy Reizenstein @.***> wrote:

Let's leave this as is.

— Reply to this email directly, view it on GitHub https://github.com/facebookresearch/pytorch3d/pull/1776#issuecomment-2043288206, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKV3UNB4U4AFSKXUNIOLPX3Y4LHNHAVCNFSM6AAAAABF3TIB36VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBTGI4DQMRQGY . You are receiving this because you authored the thread.Message ID: @.***>