facebookresearch / pytorch3d

PyTorch3D is FAIR's library of reusable components for deep learning with 3D data
https://pytorch3d.org/
Other
8.83k stars 1.32k forks source link

Citing anterior differentiable rendering working in the documentation #99

Closed martinResearch closed 4 years ago

martinResearch commented 4 years ago

🚀 Feature

The documentation page on the differentiable rendering here provides only 2 citations (Neural 3D Mesh Renderer ans Soft-Rasterizer) while there is anterior work to these differentiable renderers, some of which is cited by neither of these two papers. In the chronological order:

Also some newer paper prior to you library publication could be worth citing

I understand you library documentation is not a scientific publication and thus is not required to provide an exhaustive list of citations. However, considering the large impact your library has, it would be great for the authors of these papers if you could had these citations to your documentation.

gkioxari commented 4 years ago

Hi @martinResearch! Definitely. Thank you for the suggestions! We will include all these citations in the documentation. The reason we primarily focus on NMR and SoftRas in the documentation of our implementation is because they were the source of inspiration for our differentiable renderer. However, I completely agree that it is always good to give proper credit to more efforts out there.

gkioxari commented 4 years ago

Added DR citations by https://github.com/facebookresearch/pytorch3d/commit/112d32eaf0f25735ac1c2d76d1871a8dd8f18234. Closing this issue!