search

facebookresearch / pytorch_GAN_zoo

A mix of GAN implementations including progressive growing
BSD 3-Clause "New" or "Revised" License
1.62k stars 271 forks source link

Undefined name: 'AttribDataset' on lines 137, 142, and 304 #52

Closed cclauss closed 5 years ago

cclauss commented 5 years ago

flake8 testing of https://github.com/facebookresearch/pytorch_GAN_zoo on Python 3.7.1

$ flake8 . --count --select=E9,F63,F72,F82 --show-source --statistics

./models/trainer/DCGAN_trainer.py:19:16: F821 undefined name 'PPGANTrainer'
        return PPGANTrainer._defaultConfig
               ^
./models/metrics/nn_score.py:136:15: F821 undefined name 'AttribDataset'
    dataset = AttribDataset(pathDB, transform=transform,
              ^
./models/metrics/nn_score.py:141:25: F821 undefined name 'AttribDataset'
    validationDataset = AttribDataset(pathDB, transform=transform,
                        ^
./models/metrics/nn_score.py:303:19: F821 undefined name 'AttribDataset'
        dataset = AttribDataset(pathDB, transform=transform,
                  ^
4     F821 undefined name 'AttribDataset'
4

E901,E999,F821,F822,F823 are the "showstopper" flake8 issues that can halt the runtime with a SyntaxError, NameError, etc. These 5 are different from most other flake8 issues which are merely "style violations" -- useful for readability but they do not effect runtime safety.

Molugan commented 5 years ago

Thanks !

cclauss commented 5 years ago

I could not solve this one...

flake8 testing of https://github.com/facebookresearch/pytorch_GAN_zoo on Python 3.7.1

$ flake8 . --count --select=E9,F63,F72,F82 --show-source --statistics

./models/trainer/DCGAN_trainer.py:19:16: F821 undefined name 'PPGANTrainer'
        return PPGANTrainer._defaultConfig
               ^
1     F821 undefined name 'PPGANTrainer'
1

E901,E999,F821,F822,F823 are the "showstopper" flake8 issues that can halt the runtime with a SyntaxError, NameError, etc. These 5 are different from most other flake8 issues which are merely "style violations" -- useful for readability but they do not effect runtime safety.