search

facebookresearch / recipes

Recipes are a standard, well supported set of blueprints for machine learning engineers to rapidly train models using the latest research techniques without significant engineering overhead.Specifically, recipes aims to provide- Consistent access to pre-trained SOTA models ready for production- Reference implementations for SOTA research reproducibility, and infrastructure to guarantee correctness, efficiency, and interoperability.
BSD 3-Clause "New" or "Revised" License
284 stars 35 forks source link

[paved path] add lintrunner following pytorch #28

Open hudeven opened 2 years ago

hudeven commented 2 years ago

It's annoying to fix lint while importing code to internal. We can use the same linter(ufmt) in OSS, following what pytorch does: https://github.com/pytorch/pytorch/wiki/lintrunner

Test plan: $ pip install lintrunner $ lintrunner init $ lintrunner

image
facebook-github-bot commented 2 years ago

@hudeven has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 2 years ago

@hudeven has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot commented 2 years ago

@hudeven has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 1 year ago

Hi @hudeven!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!