Closed ezyang closed 11 months ago
This pull request was exported from Phabricator. Differential Revision: D48569957
This pull request was exported from Phabricator. Differential Revision: D48569957
This pull request was exported from Phabricator. Differential Revision: D48569957
This pull request has been merged in facebookresearch/recipes@8e5efb5bc958cda102ee91dbf5def59587eb4233.
Summary: To be a good citizen, I changed the default behavior to sample from 0 to num ids. This necessitated fixing some unit tests which had assumed that the number of ids would be fixed. I can also NOT change the default, but it seems like a good idea for the random dataset to actually have random ids by default.
Differential Revision: D48569957