Closed dstaay-fb closed 3 months ago
This pull request was exported from Phabricator. Differential Revision: D57123339
This pull request was exported from Phabricator. Differential Revision: D57123339
This pull request has been merged in facebookresearch/recipes@875435a724fa2f38ba3c778a3c7c81c333287d41.
Summary: X-link: https://github.com/pytorch/torchrec/pull/1967
As users highlighted, TrainPipeline refactoring introduced memory regression ~2% due to more context management for code readability. This results in higher peak memory (takes longer for a context to drop out of refcount)
relatively easy to get a lot more aggressive about releasing memory stored in TrainPipelineContext.
broader internal discusion: https://fb.workplace.com/groups/970281557043698/permalink/1664528510952329/
Differential Revision: D57123339
Privacy Context Container: 1203980333745195