search

facebookresearch / salina

a Lightweight library for sequential learning agents, including reinforcement learning
MIT License
426 stars 41 forks source link

Rename **args to **kwargs #16

Closed neighthan closed 3 years ago

neighthan commented 3 years ago

Some functions that accept arbitrary keyword arguments (e.g. Agents.__call__) name the keyword arguments args (e.g. __call__(self, workspace, **args)). What would you think of renaming this to __call__(self, workspace, **kwargs)? Even with the ** making it clear these were keyword arguments, I was confused for a bit thinking that these were positional arguments, since it's common to use f(*args, **kwargs) in Python. I'd be happy to submit a PR renaming any **args to **kwargs if you'll accept it; it shouldn't change anything for users since that name can only be used inside the functions. Otherwise, feel free to close this.

ludc commented 3 years ago

Hi, thanks for the remark. Please feel free to submit a PR and we will integrate it ! Thanks again