search

facebookresearch / salina

a Lightweight library for sequential learning agents, including reinforcement learning
MIT License
426 stars 41 forks source link

Rename **args to **kwargs #18

Closed neighthan closed 3 years ago

neighthan commented 3 years ago

Fixes #16.

There were a few more instances than I expected, but I think I got everything. I fixed a couple of other little issues at the same time which would have thrown errors.

I also noticed that some of the files weren't black-formatted even though the README indicated to run isort + black through pre-commit. I ran pre-commit run --all-files to fix these formatting issues. There are several unused imports (and some unused variables) too, but I didn't want to go looking for all of these, so I left the ones I saw.

facebook-github-bot commented 3 years ago

Hi @neighthan!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot commented 3 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

ludc commented 3 years ago

Thanks !