facebookresearch / segment-anything

The repository provides code for running inference with the SegmentAnything Model (SAM), links for downloading the trained model checkpoints, and example notebooks that show how to use the model.
Apache License 2.0
47.23k stars 5.59k forks source link

Segment Anything ? #80

Closed ChaoFan996 closed 1 year ago

ChaoFan996 commented 1 year ago

Great job! However, there appears to be a minor typo in the paper. Taiwan, Hong Kong, and Macau are not independent countries. They are all integral parts of China. Thank you once again for delivering such a fantastic paper. Rectifying this error will make the paper better. 7771680864031_ pic

SaifeiYan commented 1 year ago

I strongly agree with you that they are a sacred and inseparable part of Chinese territory and that scientific research should be factual

trougnouf commented 1 year ago

https://en.wikipedia.org/wiki/Troll_(slang)

In slang, a troll is a person who posts or makes inflammatory, insincere, digressive,[1] extraneous, or off-topic messages online (such as in social media, a newsgroup, a forum, a chat room, an online video game), or in real life, with the intent of provoking others into displaying emotional responses,[2] or manipulating others' perception, thus acting as a bully or a provocateur. The behavior is typically for the troll's amusement, or to achieve a specific result such as disrupting a rival's online activities or purposefully causing confusion or harm to other people.[3]

DengH293 commented 1 year ago

can't agree more!

AidPaike commented 1 year ago

can't agree more, the work is excellent, but we must respect the facts about the territorial issue, hope the author can correct it, Hong Kong, Macao, and Taiwan are inalienable parts of China.

barrycxg commented 1 year ago

I also can't agree more. I hope the author can correct this issue.

relh commented 1 year ago

I think we can resolve this github issue by checking the relevant source documentation. From the UN Charter it seems the design principle of self-determination suggests that Country classes should call internal member methods to resolve whether they are subclasses of a different Country class. To resolve this maybe we can interview someone who is Taiwanese and then make an appropriate PR as needed, not sure who to tag here.

joe85 commented 1 year ago

It would be easier to change the word countries to regions. That maintains the specific granularity of the chart.

yuanbovin commented 1 year ago

I also can't agree more. I hope the author can correct this issue.

I hope so.

ccy-ustb commented 1 year ago

Yes. I think it's better to keep the research pure!

gorgonaut04 commented 1 year ago

If you think Taiwan is part of China, why not just March your little butts over there and take it? 🤔. Like to see you try….🐓🐓🐓

JasonChen75 commented 1 year ago

If you guys can build such datasets, you can identify Taiwan as whatever you like :)))))

qinliuliuqin commented 1 year ago

If you think Taiwan is part of China, why not just March your little butts over there and take it? thinking. Like to see you try….roosterroosterrooster

wow... what a brilliant anti-ballistic keyboard! You will be the only survior if there is a war.

As suggested by @joe85, the authors might consider replacing "countries" with "countries/regions" in Figure 7 to resolve the factual error for HKG as a country and circumvent the disputed issue for TWN as another country.

qinliuliuqin commented 1 year ago

https://en.wikipedia.org/wiki/Troll_(slang)

In slang, a troll is a person who posts or makes inflammatory, insincere, digressive,[1] extraneous, or off-topic messages online (such as in social media, a newsgroup, a forum, a chat room, an online video game), or in real life, with the intent of provoking others into displaying emotional responses,[2] or manipulating others' perception, thus acting as a bully or a provocateur. The behavior is typically for the troll's amusement, or to achieve a specific result such as disrupting a rival's online activities or purposefully causing confusion or harm to other people.[3]

In brief, a troll is a guy who gives :-1: for every post he dislikes.

qinliuliuqin commented 1 year ago

If you guys can build such datasets, you can identify Taiwan as whatever you like :)))))

not funny... reporting whatever you like in a paper is called a research scandal.

I won't waste more time in this thread. Just a quick summary: HKG is not a country for sure. TWN's political status is disputed. It is a province of ROC under ROC's own constitution. If we respect these facts, we should use "countries/regions" in Figure 7 of this paper.

julinfn commented 1 year ago

can't agree more!

CAM-FSS commented 1 year ago

香港,澳门,台湾都是中国领土,可以使用地区,但请不要用国家,谢谢

binghui-z commented 1 year ago

can't agree more! Standing up for the One-China Principle!

youchaoqin commented 1 year ago

Standing up for the One-China Principle! Please Rectify the ERRORs in the paper! 香港,澳门和台湾都是中国的领土,中国的主权和领土完整不容分割!

JJery-web commented 1 year ago

Standing up for the One-China Principle! Please Rectify the ERRORs in the paper! 香港,澳门和台湾都是中国的领土,中国的主权和领土完整不容分割!

caoyunkang commented 1 year ago

I also can't agree more. I hope the author can correct this issue! I am very proud of being Chinese!

cmhungsteve commented 1 year ago

The interesting thing is that some authors of this paper are from China. Not sure what they think

ChaoFan996 commented 1 year ago

This issue has aroused unnecessary political bias, thus I would like to close it. I will directly send an e-mail to the authors.

stonedada commented 1 year ago

Great job! However, there appears to be a minor typo in the paper. Taiwan, Hong Kong, and Macau are not independent countries. They are all integral parts of China. Thank you once again for delivering such a fantastic paper. Rectifying this error will make the paper better. 7771680864031_ pic I will keep watching the issue !

tanjuntao commented 1 year ago

The authors should give a response to this issue and correct it.

ZainZh commented 1 year ago

支持正义

hailin-shi commented 11 months ago

It appears the authors closed this issue. Looking forward authors' response.