search

facebookresearch / simmc

With the aim of building next generation virtual assistants that can handle multimodal inputs and perform multimodal actions, we introduce two new datasets (both in the virtual shopping domain), the annotation schema, the core technical tasks, and the baseline models. The code for the baselines and the datasets will be opensourced.
Other
131 stars 36 forks source link

Fix support import in mm_action_prediction/tools/build_multimodal_inputs.py #55

Open e-caste opened 3 years ago

e-caste commented 3 years ago

The previous import (from tools import support) gave the following error with Python 3.8.5 on Ubuntu 20.04:

Saving dictionary: ../data/simmc_fashion/fashion_vocabulary.json
Saving embeddings: ../data/simmc_fashion/fashion_asset_embeds.npy
Traceback (most recent call last):
  File "tools/build_multimodal_inputs.py", line 18, in <module>
    from tools import support
ModuleNotFoundError: No module named 'tools'
Traceback (most recent call last):
  File "tools/build_multimodal_inputs.py", line 18, in <module>
    from tools import support
ModuleNotFoundError: No module named 'tools'
Traceback (most recent call last):
  File "tools/build_multimodal_inputs.py", line 18, in <module>
    from tools import support
ModuleNotFoundError: No module named 'tools'
Traceback (most recent call last):
  File "tools/extract_attribute_vocabulary.py", line 149, in <module>
    extract_action_attributes(parsed_args)
  File "tools/extract_attribute_vocabulary.py", line 41, in extract_action_attributes
    data = np.load(args["train_npy_path"], allow_pickle=True)[()]
  File "/home/$USER/path/simmc/venv/lib/python3.8/site-packages/numpy/lib/npyio.py", line 416, in load
    fid = stack.enter_context(open(os_fspath(file), "rb"))
FileNotFoundError: [Errno 2] No such file or directory: '../data/simmc_fashion/fashion_train_dials_mm_inputs.npy'
facebook-github-bot commented 3 years ago

Hi @e-caste!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

e-caste commented 3 years ago

I have signed the CLA, the automated test should pass now. I think I don't have access to re-run it, so I'll just leave a comment here.

facebook-github-bot commented 3 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!