facebookresearch / spdl

Scalable and Performant Data Loading
BSD 2-Clause "Simplified" License
44 stars 2 forks source link

Fix shadowed variable in spdl/src/libspdl/core/detail/nvjpeg/decoding.cpp #248

Closed r-barnes closed 3 weeks ago

r-barnes commented 3 weeks ago

Summary: Our upcoming compiler upgrade will require us not to have shadowed variables. Such variables have a high bug rate and reduce readability, so we would like to avoid them even if the compiler was not forcing us to do so.

This codemod attempts to fix an instance of a shadowed variable. Please review with care: if it's failed the result will be a silent bug.

What's a shadowed variable?

Shadowed variables are variables in an inner scope with the same name as another variable in an outer scope. Having the same name for both variables might be semantically correct, but it can make the code confusing to read! It can also hide subtle bugs.

This diff fixes such an issue by renaming the variable.

Differential Revision: D64398711

facebook-github-bot commented 3 weeks ago

This pull request was exported from Phabricator. Differential Revision: D64398711