search

facebookresearch / spot-sim2real

Spot Sim2Real Infrastructure
MIT License
83 stars 7 forks source link

Update timeout to None from 1 min #234

Closed KavitShah1998 closed 1 month ago

KavitShah1998 commented 1 month ago

This PR solves the ROSBridge timeout error issue that we used to see in hab-llm

We used to ignore this error but if a subscriber timeout, it will stop receiving any further msgs about that topic. This was now becoming an issue for image detection strings. Thus fixing this asap is super important

KavitShah1998 commented 1 month ago

Currently not having timeout set to None is causing blockers.

@tusharsangam do you think setting timeout to None can cause any blocking issues?

KavitShah1998 commented 1 month ago

Does self.socket.settimeout(None) block the execution, which means the code would only continue once we receive the images?

timeout is mainly to say how long should I keep this service alive. So if timeout is 90, it will keep service alive for 90 seconds of inactivity and then trigger error.

If timeout is None, it means no need to die , just keep listening.

KavitShah1998 commented 1 month ago

@jimmytyyang

@tusharsangam has verbally approved the PR on slack. Will merge the PR