search

facebookresearch / swav

PyTorch implementation of SwAV https//arxiv.org/abs/2006.09882
Other
2.01k stars 280 forks source link

Changes to standard ResNet #81

Closed kshen6 closed 3 years ago

kshen6 commented 3 years ago

Hi authors, Thanks for making this repository public, it's excellent and easy to use! I had one question about the update you made to the resnet50.py code on line 157. Is there somewhere in the paper that the extra padding is discussed (if there is, I couldn't find it), or can you explain why it is necessary? I am trying to implement SwAV for DenseNets and am wondering if the padding should be added there as well. Thanks so much in advance.

mathildecaron31 commented 3 years ago

Hi @kshen6

With the padding the implementation is strictly equivalent to that of torchvision since the padding in the first conv is 2 instead of 3 in torchvision.

The padding layer is there because of previous experiments that I did and that required it. You could very well remove the padding layer and use padding=3 instead of padding=2 here: https://github.com/facebookresearch/swav/blob/5e073db0cc69dea22aa75e92bfdd75011e888f28/src/resnet50.py#L173-L177

kshen6 commented 3 years ago

Thank you for the prompt and helpful reply. Closing this thread!