search

facebookresearch / synsin

View synthesis for the public.
http://www.robots.ox.ac.uk/~ow/synsin.html
Other
659 stars 93 forks source link

remove params in models/layers/z_buffer_layers.py #19

Closed FengQiaojun closed 3 years ago

FengQiaojun commented 3 years ago

As it is mentioned in issues/18, this removes the unused params to align with pytorch v0.2.0.

However, I did observe slight different between the figures generated from Simple Demo.ipynb after the change.

Before (the default cached figure in the origin .ipynb) default After the change after Difference in the curtain area after the sofa.

You can investigate whether anything might be actually affected by the change.

Thanks

facebook-github-bot commented 3 years ago

Hi @FengQiaojun!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

FengQiaojun commented 3 years ago

I signed the CLA now but not sure how to re-run the check.

facebook-github-bot commented 3 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

gkioxari commented 3 years ago

Thank you @FengQiaojun

oawiles commented 3 years ago

I think it should be the same: I checked the code and the radius is only being used in the rasterize_points method and it's being passed there. So I think it's fine.

gkioxari commented 3 years ago

@oawiles exactly! I went ahead and merged it because I feel responsible for this change as I was the one who removed the composite_params from PyTorch3D! :D