facebookresearch / textlesslib

Library for Textless Spoken Language Processing
MIT License
518 stars 50 forks source link

Update HubertFeatureReader to skip small chunks #11

Open many-hats opened 2 years ago

many-hats commented 2 years ago

Very rarely, if the chunk is smaller than the kernel size and larger than the max_chunk size (e.g. (x.size(1) % max_chunk) < 10), the feature reader will produce a runtime error:

RuntimeError: Calculated padded input size per channel: (1). Kernel size: (10). Kernel size can't be greater than actual input size

I ran into this error when transcribing libri-light large with hubert-base-ls960 where there are two files that would produce this error and kill the job: 6454/13348/vicksburgnational_03_everhart_64kb_0014.flac with duration 1600001 and 9221/9912/cloudstudies_08_clayden_64kb_0016.flac with duration 3200001.

facebook-github-bot commented 2 years ago

Hi @many-hats!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot commented 2 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot commented 2 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!