Implementation of multi-batch unary Lie group operators - Githubissues

facebookresearch / theseus

A library for differentiable nonlinear optimization

MIT License

1.78k stars 128 forks source link

Implementation of multi-batch unary Lie group operators #509

Closed fantaosha closed 1 year ago

fantaosha commented 1 year ago

Motivation and Context

How Has This Been Tested

Types of changes

[ ] Docs change / refactoring / dependency upgrade
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have completed my CLA (see CONTRIBUTING)
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

luisenp commented 1 year ago

Let's keep this PR only for SO3. The unit tests we can also leave for a separate PR, since it requires some discussion. Are there any other TODOs left before merging this?