facebookresearch / theseus

A library for differentiable nonlinear optimization
MIT License
1.78k stars 128 forks source link

Revisit Lie group consistency checks #521

Closed luisenp closed 1 year ago

luisenp commented 1 year ago

We have observed some 64-bit SE2 tensors with cosines slightly larger than ones sneaking through after application of retraction maps. We should consider making the Lie group checks stronger to prevent issues like this. Another option would be to normalize all exp_map outputs (e.g., here).

mhmukadam commented 1 year ago

Is this happening in the new Lie groups too?

mhmukadam commented 1 year ago

Flagging unresolved comments from #528 that need to be resolved with this issue.

luisenp commented 1 year ago

Closed by #544