facebookresearch / theseus

A library for differentiable nonlinear optimization
MIT License
1.74k stars 124 forks source link

Yipuz.more robust loss #581

Closed YipuZhao closed 1 year ago

YipuZhao commented 1 year ago

Motivation and Context

Adding two robust loss implementations to extend the types of inner optimization in theseus:

How Has This Been Tested

Hinge loss is added to existing robust loss test script; GNC loss is covered by a new test script adapted upon existing robust loss unit test.

Types of changes

Checklist

YipuZhao commented 1 year ago

Thanks a lot for this contribution @YipuZhao! Mostly code structure changes for now (haven't checked the math).

Can you also add a comment with a reference link to where these losses are described (like a paper or book citation/link).

Thanks for the review! I revised things per your comment, but for now kind of stucked at precommit hook (comment above) and curious about your take. Thanks for any suggestions!

YipuZhao commented 1 year ago

Thanks for adding this @YipuZhao!

Thanks for the comments! Revised and rebased :)