Speedup VariableOrdering.append from O(N^2) to O(N)

[ahojnnes]

Motivation and Context

When specifying the ordering for larger problems with many thousands of variables, the current implementation becomes very slow due to the O(N^2) complexity caused by the O(N) complexity of checking existence of var in the _var_order list. For small problems, the new implementation is a little slower but the difference is negligible. For large problems, the speed goes down from multiple 10s of seconds to

How Has This Been Tested

The runtime has been tested on various bundle adjustment problems. The functionality should be covered by existing unit tests with unchanged behavior.

Types of changes

• [ ] Docs change / refactoring / dependency upgrade
• [x] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• [x] My code follows the code style of this project.
• [ ] My change requires a change to the documentation.
• [ ] I have updated the documentation accordingly.
• [x] I have read the CONTRIBUTING document.
• [ ] I have completed my CLA (see CONTRIBUTING)
• [ ] I have added tests to cover my changes.
• [x] All new and existing tests passed.

[facebook-github-bot]

Hi @ahojnnes!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[ahojnnes]

CI failures seem unrelated to the changes in this PR.

[luisenp]

Thanks so much for this fix. It's unfortunate how such a careless but small oversight had so large of an impact. I'll make another PR first to fix the CI errors. Then we can merge.

[luisenp]

@ahojnnes Ci should be fixed now if you rebase on top of latest main.

[ahojnnes]

@luisenp Thanks for fixing the CI. I rebased on latest master. Cheers.

[ahojnnes]

@luisenp Another (seemingly transient) CI failure. Might need a retrigger of the build, which I don't have permission for.