facebookresearch / theseus

A library for differentiable nonlinear optimization
MIT License
1.78k stars 128 forks source link

Bug fix for the batched LM #664

Open lpanaf opened 1 month ago

lpanaf commented 1 month ago

For the current code, if some batches are rejected, they would be considered as converged in the following steps, since the error of those batch are not changed.

How Has This Been Tested

Types of changes

Checklist

facebook-github-bot commented 1 month ago

Hi @lpanaf!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

facebook-github-bot commented 1 month ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

luisenp commented 1 month ago

Hi @lpanaf. Thanks so much for catching this error and your contribution! Before merging, it looks like our lint checks are not passing. Would you mind installing the code style checks as explained in this document and using the command explained in the "Code Style" section? Thanks!