search

facebookresearch / torchbeast

A PyTorch Platform for Distributed RL
Apache License 2.0
738 stars 114 forks source link

Missing PyTorch in the requirements.txt? #1

Closed samvelyan closed 5 years ago

samvelyan commented 5 years ago

Hi there. Congratulations on the release. The platform looks great.

After following the installation guide for MonoBeast

$ conda create -n torchbeast python=3.7
$ conda activate torchbeast
$ pip install -r requirements.txt

and running 

python -m torchbeast.monobeast --env PongNoFrameskip-v4

I'm getting the following error ModuleNotFoundError: No module named 'torch'.

Looks like you're missing the torch prerequisite in the requirements.txt for the new torchbeast conda environment.

heiner commented 5 years ago

Hey Mikayel, thanks for the kind words!

You're absolutely right. We avoided adding PyTorch to requirements.txt in order to let users choose their preferred version, and because the installation for PolyBeast on Linux requires a special version of PyTorch due to binary incompatibilities. In https://github.com/facebookresearch/torchbeast/commit/7b5dd9a477fd7258ec7d582e08f3d8c04d2ac156 we added a PyTorch installation command to the installation guide.

Thanks for telling us and have fun using TorchBeast!