search

facebookresearch / vissl

VISSL is FAIR's library of extensible, modular and scalable components for SOTA Self-Supervised Learning with images.
https://vissl.ai
MIT License
3.25k stars 331 forks source link

add option to register custom models #416

Closed mayalenE closed 2 years ago

mayalenE commented 3 years ago

This pull request is related to issue #411

mayalenE commented 3 years ago

Hello, can you update on the status on this pull request: it seems like there are some troubles with the ci/circleci tests (?) It fails to pip install classy_vision...

Thanks!

iseessel commented 3 years ago

@prigoyal @QuentinDuval Can you guys look at this and let me know what you think?

I think given our commitment to flexibility, it makes sense to be able to override BaseSSLMultiInputOutputModel, as well as the TRUNK and HEAD. User had issues https://github.com/facebookresearch/vissl/issues/411 where specifying TRUNK and HEAD wasn't enough to solve.

prigoyal commented 2 years ago

this is a good PR / feature to have in VISSL. @iseessel , let's sync on this offline.

facebook-github-bot commented 2 years ago

@iseessel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot commented 2 years ago

@iseessel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot commented 2 years ago

@mayalenE has updated the pull request. You must reimport the pull request before landing.

mayalenE commented 2 years ago

Hello, sorry for the delay where are we with the PR @iseessel? I modified config.MODEL.NAME into config.MODEL.BASE_MODEL_NAME as requested by @prigoyal

iseessel commented 2 years ago

@mayalenE Just getting through final reviews -- should be done soon!

facebook-github-bot commented 2 years ago

@iseessel merged this pull request in facebookresearch/vissl@9be692c4ce2f9abc2331d73d97bf1d0461c53adc.