search

facebookresearch / vissl

VISSL is FAIR's library of extensible, modular and scalable components for SOTA Self-Supervised Learning with images.
https://vissl.ai
MIT License
3.24k stars 330 forks source link

VISSL & Detectron Installation Instruction Conflict #517

Open ysharma1126 opened 2 years ago

ysharma1126 commented 2 years ago

Minor note, the torch version recommended to install in the VISSL instructions appears to be incompatible with the object detection benchmark dependency Detectron2, which appears to require PyTorch ≥ 1.8, see here.

QuentinDuval commented 2 years ago

Hi @ysharma1126,

Indeed, good catch!

I think we could update the PyTorch version to 1.8 and higher (we do work with VISSL on our side with higher versions like 1.8, 1.9 or more). I will delegate this question to @iseessel though, since he is more knowledgable on the packaging / dependencies than me.

Side note: Once thing I am not 100% sure is whether it is a good idea anyway to use the same conda environment for detectron2 and VISSL (since it introduces some coupling of dependency versions). Although we do have a script to run detectron2, I must admit I never played with object detection for now, maybe we could find a better way.

Back on the point @ysharma1126, since @iseessel is off this week, the response might take some time.

Thank you again for raising this :) Quentin

ysharma1126 commented 2 years ago

No worries, no urgency on my end :)

iseessel commented 2 years ago

@ysharma1126 Yes you should be able to update the pytorch version to whatever version is compatible with Detectron. Let me know if you need any guidance on how to do this.