search

facebookresearch / vizseq

An Analysis Toolkit for Natural Language Generation (Translation, Captioning, Summarization, etc.)
https://arxiv.org/abs/1909.05424
MIT License
443 stars 59 forks source link

Update bert_score.py #6

Closed Patil2099 closed 5 years ago

Patil2099 commented 5 years ago

Fixes #5

facebook-github-bot commented 5 years ago

Hi Patil2099! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot commented 5 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

kahne commented 5 years ago

Thanks for the PR! #7 has a fix on this, which uses the lang argument instead of model_type. This allows bert-score to adaptively choose the best model for the current language.