Rapidjson helpers clean-up - Githubissues

facebookresearch / vrs

VRS is a file format optimized to record & playback streams of sensor data, such as images, audio samples, and any other discrete sensors (IMU, temperature, etc), stored in per-device streams of timestamped records.

https://facebookresearch.github.io/vrs/

Apache License 2.0

323 stars 55 forks source link

Rapidjson helpers clean-up #123

Closed georges-berenger closed 1 year ago

georges-berenger commented 1 year ago

Summary:

renamed a json helper functions to be more specific, to reduce chances of name collisions
parameter types clean-up for consistency, better match underlying API, or address linter comment
removed duplicate local helper function (same name, different parameter order)
use helper in a few places where we could have.

No behavior change expected.

Differential Revision: D46267101

facebook-github-bot commented 1 year ago

This pull request was exported from Phabricator. Differential Revision: D46267101

facebook-github-bot commented 1 year ago

This pull request was exported from Phabricator. Differential Revision: D46267101

facebook-github-bot commented 1 year ago

This pull request was exported from Phabricator. Differential Revision: D46267101

facebook-github-bot commented 1 year ago

This pull request was exported from Phabricator. Differential Revision: D46267101

facebook-github-bot commented 1 year ago

This pull request was exported from Phabricator. Differential Revision: D46267101

facebook-github-bot commented 1 year ago

This pull request was exported from Phabricator. Differential Revision: D46267101

facebook-github-bot commented 1 year ago

This pull request was exported from Phabricator. Differential Revision: D46267101

facebook-github-bot commented 1 year ago

This pull request was exported from Phabricator. Differential Revision: D46267101