Closed qianfengz closed 4 months ago
Are you able to see the lint failures? There are a few to fix here.
Let me check.
@bottler There is a checking failure about the copyright for file xformers/csrc/attention/hip_fmha/generate_instances.py
. Is any way to fix the issue? If not, I can just remove the script, cause it is only used for convenience by the developer to create the instance cpp files
@bottler There is a checking failure about the copyright for file
xformers/csrc/attention/hip_fmha/generate_instances.py
. Is any way to fix the issue? If not, I can just remove the script, cause it is only used for convenience by the developer to create the instance cpp files
Can you add # noqa: C801
to the first line of the file?
@bottler There is a checking failure about the copyright for file
xformers/csrc/attention/hip_fmha/generate_instances.py
. Is any way to fix the issue? If not, I can just remove the script, cause it is only used for convenience by the developer to create the instance cpp filesCan you add
# noqa: C801
to the first line of the file?
Added.
I think dispatch.py has had a bad merge with recent changes on main? You are losing unpadded_lse
logic from _dispatch_bw.
I think dispatch.py has had a bad merge with recent changes on main? You are losing
unpadded_lse
logic from _dispatch_bw.
Fixed, thank you for pointing out
The last test failures are not caused by this PR. Black is needed on test_mem_eff_attention.py and generate_instances.py and that's all.
Based on the existing available ck fmha functions on the main branch, this PR add the followings:
To test/verify