facebookresearch / xformers

Hackable and optimized Transformers building blocks, supporting a composable construction.
https://facebookresearch.github.io/xformers/
Other
8.66k stars 614 forks source link

Remove _check_large_shapes checking in fmha/ck.py #1067

Closed qianfengz closed 4 months ago

qianfengz commented 4 months ago

It makes no sense to use _check_large_shapes() to add unintended restriction to the input sizes of the CK fmha fwd/bwd operator. So just remove it.

bottler commented 4 months ago

Great, thanks. Please run black - I think you just need an extra blank line after line 103 - and then I'll merge. Or let me know if that's difficult.

qianfengz commented 4 months ago

Great, thanks. Please run black - I think you just need an extra blank line after line 103 - and then I'll merge. Or let me know if that's difficult.

Added blank line, sorry for late response. Thank you!