Closed warpuv closed 2 weeks ago
@danthe3rd, @lw, @zyan0 Can you review this PR please? This update will open pass to implement fused GELUTanh for Gemma models
Hi @pansershrek and @warpuv Thanks for opening this PR. In principle I'm happy to accept this line of contributions, however you should be aware that:
B0
and B1
columns, so that the output of the GEMM is also interleaved, and the activation can still be fused in the epilogue in the same way (but the rest of the GEMM is untouched)cc @tridao
Hi @danthe3rd ! Thank you for your replay, can you explain in more details your advice about B0 and B1 columns? We don't understand the difference in architecture that well as you :) .
Generalization of dual_gemm_silu_identity_mul to use custom activation function.
What does this PR do?
Fixes #1140
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed. If we didn't discuss your PR in Github issues there's a high chance it will not be merged.