facelessuser / BracketHighlighter

Bracket and tag highlighter for Sublime Text
https://facelessuser.github.io/BracketHighlighter/
1.74k stars 245 forks source link

Use `['__all__']` as the default for `type` #604

Closed FichteFoll closed 1 year ago

FichteFoll commented 2 years ago

When building generic key bindings, for example to select/move to brackets, you must specify "type": ["__all__"] for all of them because an empty or not provided value will cause the module to not be executed at all.

I propose to make the default behave as if it was selected for all bracket types because that behavior seems to be used rather frequently. In the example keymap referenced above, 7 out of 11 use exactly that value for type and for the ones where it doesn't it's rather self-explanatory why the type needs to be restricted.

facelessuser commented 2 years ago

This is a fair argument. I can't recall my thinking at the time that moved me in this direction, but your argument makes sense.

@gir-bot add T: feature @gir-bot remove S: triage