ST ColorMod `blend(a)` adjusters not working - Githubissues

facelessuser / ColorHelper

Sublime plugin that provides helpful color previews and tooltips

https://facelessuser.github.io/ColorHelper/

MIT License

256 stars 31 forks source link

ST ColorMod `blend(a)` adjusters not working #206

Closed AmjadHD closed 2 years ago

AmjadHD commented 2 years ago

Description

ST color-mod blend(a) adjusters don't work:

Support Info

ST ver.: 4121
Platform: windows
Arch: x64
Plugin ver.: 3.8.0
Install via PC: True
mdpopups ver.: 4.2.1

Steps to Reproduce Issue

Run Color Helper: ST ColorMod from the CP
Paste color(red blenda(green 15%))

facelessuser commented 2 years ago

Did you mean to use blenda?

AmjadHD commented 2 years ago

Yes, both blend and blenda don't work.

facelessuser commented 2 years ago

Okay, I'll take a look

facelessuser commented 2 years ago

I imagine a regression occurred at some point.

facelessuser commented 2 years ago

Turns out that during an update of the internal coloraide, some of the color parts regex that we reuse added some captured groups in the regex where they used to be uncaptured. This caused us to access the wrong matched groups during blend and broke us. I'll have a fix in the next version.

facelessuser commented 2 years ago

The fix is on master. I should get a release out in the next few days. Blend and blenda are now fixed, and even s() and l() needed a fix as the scaling of HSL non-hue values is now between 0 - 1 instead of 0 - 100 in the coloraide object. Anyways, this will be available soon-ish.