Closed gosxrgxx closed 3 months ago
Thanks for the pull, I'll try to evaluate it sometime soon.
@gosxrgxx, I think you want a pattern more like:
(?i)(?:\\b(?<![-#&$])(?:color\\((?!\\s*-)|(?:hsla?|(?:ok)?(?:lch|lab)|hwb|rgba?)\\()|\\b(?<![-#&$])[\\w]{3,}(?![(-])\\b|(?<![&])\\#)
I think that is the default pattern though, so you can just remove that pattern entry entirely.
To exclude color names (green, red, etc.). Perhaps you can suggest a more suitable solution.
When I'm adding such rules, I'm keeping them generic as everyone may want different things. INI files don't have innate color requirements.
If a specific file type has a specific spec in relation to colors, that is generally when we are more selective.
Ok. In that case, should I remove the line with the regular expression, or will you do it?
Ideally, you could make the change in this PR.
@gir-bot lgtm
Support colors for .ini files