search

facelessuser / MarkdownPreview

Markdown preview and build plugin for Sublime Text https://facelessuser.github.io/MarkdownPreview/
Other
402 stars 53 forks source link

Added configurable Gitlab domain. #134

Open ghost opened 2 years ago

ghost commented 2 years ago

This (partially) closes issues #44 . I have only a Gitlab custom domain to test with, so that's why I cannot provide a similar change for the Github part.

facelessuser commented 2 years ago

@ba-tno thanks for this pull! I'm wondering if it would be useful to make the setting a list and prompt the user for the domain if the setting provides more than one. There may be reasons to use one domain for certain files and another for other files.

This is more a question as I'm just thinking about usefulness.

ghost commented 2 years ago

Sorry, I see now that I botched it by calling self in the class variable... I'll have to take a look again anyways, so I'll see if I can get a list working as well (something similar to the enabled_parsers setting).

facelessuser commented 2 years ago

As things have gone silent on this, I may just end up coming back and refactoring this to address related issues.