facelessuser / MarkdownPreview

Markdown preview and build plugin for Sublime Text https://facelessuser.github.io/MarkdownPreview/
Other
402 stars 53 forks source link

github preview output not responsive. #180

Closed R4wd0g closed 3 months ago

R4wd0g commented 3 months ago

Hello folks. Here i cannot manage to make the github markdown browser window to be responsible when changing the window size of the browser. It's weird cause this behavior doens't occur on others parsers like markdown, or gitlab. thanks

img
facelessuser commented 3 months ago

I don't think I understand what you are describing.

R4wd0g commented 3 months ago

I don't think I understand what you are describing.

thanks for answering. Can u see that the text are cropped? The text formatting does't follow the window resize. How would you name this phenomenon?

facelessuser commented 3 months ago

It probably has a minimum width.

R4wd0g commented 3 months ago

It probably has a minimum width.

it's weird, because on parser "markdown" or "gitlab", this behavior doesn'r occur. Do happens the same at your side?

facelessuser commented 3 months ago

Somehow we have a discrepancy where the others use a max size of \ and GitHub uses a size of \. One allows shrinking, the other does not.

R4wd0g commented 3 months ago

Somehow we have a discrepancy where the others use a max size of and GitHub uses a size of . One allows shrinking, the other does not.

But, on GitHub website, the text formatting follows the window size. You can compare by yourself at readme page: https://github.com/facelessuser/MarkdownPreview/

Sorry if it isn't a bug. But some limitation of the plugin.

facelessuser commented 3 months ago

No, i just mentioned there is a discrepancy in the CSS we provide for GitHub and the CSS we provide for the others. That means we need to update our GitHub CSS.

facelessuser commented 3 months ago

Fix is here: https://github.com/facelessuser/MarkdownPreview/commit/c94a1e0465188b4b526d95adeef773b88f72b928

R4wd0g commented 3 months ago

Fix is here: c94a1e0

Thanks @facelessuser , you approach has fixed the issue successfully. Kindly, i made a pull request of a minimal modification to make the content fit better. bless you