search

facelessuser / MarkdownPreview

Markdown preview and build plugin for Sublime Text https://facelessuser.github.io/MarkdownPreview/
Other
405 stars 53 forks source link

Sublime freezes while previewing in qutebrowser or surf #72

Closed lairdchris closed 5 years ago

lairdchris commented 5 years ago

When I set qutebrowser or surf (suckless.org) as browser, Sublime freezes until I close the preview again. Setting it to vivaldi works as expected.

My configuration: Ubuntu 18.10, Sublime Build 3176, MarkdownPreview 2.2.2

diffficult commented 5 years ago

same issue. Maybe you need to add something else to the browser path?

my setup

{
    /*
        Sets the default opener for HTML files

        default - Use the system default HTML viewer
        other - Set a full path to any executable. ex: /Applications/Google Chrome Canary.app or /Applications/Firefox.app
    */
    "browser": "/usr/local/bin/surf",
}
diffficult commented 5 years ago

Still not working with surf, Sublime still freezed in the background til you close browser window displaying preview. Other than that preview looks fine and file is created where it was supposed to or using the path in your config file.

facelessuser commented 5 years ago

@diffficult, I'm confused, are you saying that @lairdchris's pull request doesn't fix your issue? The issue was closed because @lairdchris opened a pull request that addresses the issue.

diffficult commented 5 years ago

@facelessuser I'm sorry, I thougth this was already reflected after updating the package with Package Control

facelessuser commented 5 years ago

No, I didn't even close this issue. I usually don't close an issue until the fix is merged, and even then releases don't always happen right after I merge a fix.

I'll reopen this for now as I haven't merged the fix yet.

facelessuser commented 5 years ago

So the reason for this issue is because this project, before my time, was written for ST2. ST3 support was added, but clearly not tested in great detail as the linux2 worked in ST2 which ran on Python 2.6. But this was convention of including Linux major version was discontinued in Python 3.3 which ST3 relies on.

lairdchris commented 5 years ago

Sorry for the confusion. The issue was autoclosed because of my reference in the commit comment... I'm new to this pull request business ;-)

diffficult commented 5 years ago

@facelessuser I see, thanks for checking it out

@lairdchris no problem, also new with this and even though I was using this package for a while now on Windows noticed the issue after making the jump to a new Linux desktop.

facelessuser commented 5 years ago

Usually GitHub doesn't autoclose until the pull is merged, but it's no big deal.