search

facelessuser / MarkdownPreview

Markdown preview and build plugin for Sublime Text https://facelessuser.github.io/MarkdownPreview/
Other
405 stars 53 forks source link

Fixed obvious typo #73

Closed lairdchris closed 5 years ago

lairdchris commented 5 years ago

Fixed typo that prevents Linux from being recognized as platform and starting the preview as background process, thus freezing Sublime while the preview is open.

resolves #72

facelessuser commented 5 years ago

I don't think this is an obvious typo. I believe linux2 is a valid return. I didn't originally write this part, but maybe you need linux2 and linux? It maybe just default to assuming Linux if we don't match windows or macOS.

lairdchris commented 5 years ago

Well, the Python documentation only mentions 'linux' as valid platform value, besides Win and MacOS https://docs.python.org/3/library/sys.html?highlight=system%20platform#sys.platform

'linux2' was valid before, so my typo assumption is actually wrong.

facelessuser commented 5 years ago

Ah, yes, I guess linux2 and linux3 was a Python 2 and Python < 3.3 thing. So yes, as far as Python 3.3 is concerned (what Sublime uses) we don't need linux2.