search

facelessuser / Rummage

Rummage is a GUI for grep like searches in Python
https://facelessuser.github.io/Rummage/
MIT License
74 stars 10 forks source link

Update gen_docs.py #413

Closed ghost closed 3 years ago

ghost commented 3 years ago

Improve code.

facelessuser commented 3 years ago

While I appreciate your desire to contribute to this project, I, unfortunately, cannot merge this.

  1. Changes currently break the execution of the test and breaks other tests.

  2. I see nothing in the request that makes things arguably better. At best I see some preferential changes.

In future pulls, I would make sure the changes get tested, and also provide an argument of why desired changes are considered needed in the pull request description.

I wanted to, at the very least, let you know why I will not be considering this pull.

@gir-bot add S: rejected

ghost commented 3 years ago

sorry, that was a "fishing PR" with intentioanl crap to make sure the people responsible for the repo are not accepting PR without appropriate checks. You pass!

facelessuser commented 3 years ago

Thanks...I guess?