facelessuser / Rummage

Rummage is a GUI for grep like searches in Python
https://facelessuser.github.io/Rummage/
MIT License
74 stars 10 forks source link

Support Python 3.11 #441

Closed facelessuser closed 1 year ago

facelessuser commented 1 year ago

We are waiting for WxPython release with Py 3.11 wheels. As soon as these drop, we will verify the build and make a release after fixing any Py 3.11 related issues (assuming any).

facelessuser commented 1 year ago

Python 3.11 support for wxPython is now available, we should do some testing and release a new version. I believe early 3.12 support is also available. I'll need to make sure everything in the dependency chain that I support is ready for 3.12, but we can probably get support for both in.

facelessuser commented 1 year ago

We may need to wait for 3.12. We have wxPython support, but babel does not support it yet.

facelessuser commented 1 year ago

Python 3.11 seems to require MacNewFile for the initial window focus where MacReopenApp was enough on mac.

facelessuser commented 1 year ago

The original cchardet that was maintained by PyYoshi is no longer maintained and hasn't been since around 2020. The project continued to build fine, but it no longer builds for Python 3.11+. We've switched to faust-cchardet which is a fork that builds and provides wheels for all of our supported Python versions, even 3.11.

facelessuser commented 1 year ago

At some point horizontal static lines became invisible on macOS. This is true for older versions of wxPython. It was subtle, and I never noticed. But on the recent versions of wxPython vertical lines have become ugly.

Screenshot 2023-06-29 at 7 38 19 AM

While this is clearly a bug in wxPython, the question is whether we can do anything to mitigate the issue in Rummage.

facelessuser commented 1 year ago

Compare current:

Screenshot 2023-06-29 at 7 48 11 AM

With how it used to look:

preview
facelessuser commented 1 year ago

Issue created: https://github.com/wxWidgets/Phoenix/issues/2428

facelessuser commented 1 year ago

We are just going to hide it on mac (vertical separator) until it gets fixed.

facelessuser commented 1 year ago

Separate issue created for static lines: https://github.com/facelessuser/Rummage/issues/446. We will mitigate the look by hiding it, but the issue will track the problem until there is a resolution that allows us to remove the workaround.