search

facelessuser / Rummage

Rummage is a GUI for grep like searches in Python
https://facelessuser.github.io/Rummage/
MIT License
74 stars 10 forks source link

Look into command line app not always being available #457

Open facelessuser opened 3 months ago

facelessuser commented 3 months ago

This was discussed in this issue #454.

facelessuser commented 3 months ago

When we migrated to hatch, we started to use a custom hook so we could generate command line references of rummage and rummageX.X, where X.X is the Python version. This hook was given to us by the author of Hatch, so it should work.

The first thing to try is to probably not use a dynamic hook and just generate rummage and see if we can get that to update properly. If that works, we can point to hatch as having a problem or changing something under the hood.

If not using a dynamic hook is also problematic, then we may have a fundamental issue if we are defining the command line app according to the official recommendations and it still isn't working.

facelessuser commented 3 months ago

It may be that if not using a dynamic hook fixes it, we may abandon the rummageX.X approach moving forward, though it would be nice to learn why it suddenly stopped working.

facelessuser commented 3 months ago

https://github.com/pypa/hatch/issues/1364

facelessuser commented 3 months ago

I should be able to work around this with a static command line of rummage.

facelessuser commented 3 months ago

The bug has been confirmed to be in hatch, or I should say hatchling.

toxpal commented 3 months ago

For me fixing this issue https://github.com/facelessuser/Rummage/issues/459 also fixed command line availability :) "rummage" command works again as usually

facelessuser commented 3 months ago

The command line fix is a coincident, hatchling fixed the issue and recently released a new version: https://github.com/pypa/hatch/releases/tag/hatchling-v1.22.5.

So that wraps up the messiest series of releases for Rummage 😬.