facelessuser / Rummage

Rummage is a GUI for grep like searches in Python
https://facelessuser.github.io/Rummage/
MIT License
74 stars 10 forks source link

Linux title doesn't show up #459

Closed facelessuser closed 3 months ago

facelessuser commented 3 months ago

https://github.com/facelessuser/Rummage/issues/458#issuecomment-2037087138

facelessuser commented 3 months ago

@toxpal I will need more info.

I get this GTK error, but it doesn't seem to affect the title at all. Whatever it does affect, seems to not be a noticeable issue.

(__main__.py:5898): Gtk-CRITICAL **: 15:36:40.361: gtk_widget_set_size_request: assertion 'height >= -1' failed

Can you run with --debug and see if there are some usable errors emitted?

toxpal commented 3 months ago

Nothing unusual, I think:

DEBUG: Object{
    "__format__": "2.6.1",
    "alert_enabled": false,
    "alt_list_color": true,
    "autocomplete": false,
    "backup_ext": "rum-bak",
    "backup_folder": ".rum-bak",
    "backup_type": 0,
    "brace_expansion": false,
    "chains": {},
    "check_prerelease": false,
    "check_updates": false,
    "current_version": [
        4,
        20,
        1,
        "final",
        0,
        0,
        0
    ],
    "editor": "\"kate\" \"{$file}:{$line}:{$col}\"",
    "encoding_options": {
        "bin": [
            ".bin",
            ".jpg",
            ".jpeg",
            ".png",
            ".gif",
            ".ttf",
            ".tga",
            ".dds",
            ".ico",
            ".eot",
            ".pdf",
            ".swf",
            ".jar",
            ".zip",
            ".exe"
        ],
        "chardet_mode": 0,
        "html": [
            ".html",
            ".htm",
            ".xhtml"
        ],
        "python": [
            ".py",
            ".pyw"
        ],
        "xml": [
            ".xml"
        ]
    },
    "extmatch": false,
    "file_case_sensitive": false,
    "full_exclude_path": false,
    "full_file_path": false,
    "globstar": false,
    "hide_cols_content": [],
    "hide_cols_file": [
        5,
        6,
        7
    ],
    "international_time": true,
    "last_update_check": "2024-04-04 09:50",
    "locale": "en_US",
    "matchbase": false,
    "minusnegate": false,
    "notify_enabled": false,
    "notify_method": "default",
    "notify_player": "paplay",
    "notify_sound": "",
    "pattern_limit": 1000,
    "pos_cols_content": [],
    "pos_cols_file": [
        0,
        1,
        2,
        4,
        3,
        6,
        7,
        5
    ],
    "regex_mode": 0,
    "regex_version": 0,
    "saved_searches": {},
    "single_instance": false,
    "term_notifier": ""
}

DEBUG: ----Intial screen resize----
DEBUG: Screen Index: 0
DEBUG: Screen Client Size: 2560 x 1396
DEBUG: Window Size: 825 x 711
DEBUG: ----Intial screen resize----
DEBUG: Screen Index: 0
DEBUG: Screen Client Size: 2560 x 1396
DEBUG: Window Size: 825 x 711
toxpal commented 3 months ago

Just to let you know that I previously used "rummage" command to launch app, and title worked perfectly. However, because of issue with v4.20.x, I use "python3 -m rummage" command to launch app, and title doesn't appear anymore. Maybe that's related?

facelessuser commented 3 months ago

When I tested on Ubuntu, I used python3 -m rummage and title rendered fine. I don't recall though, what distro and version of said distro are you using? If I'm not able to reproduce, it will be difficult to fix.

facelessuser commented 3 months ago

I think I found the cause...it happens when you disable autocomplete 🤦🏻

facelessuser commented 3 months ago

I have a fix. It wasn't linux specific at all. We were kicking out of a function to avoid handling autocomplete, but we weren't calling the callback function (which in this case updates the title).

facelessuser commented 3 months ago

Fixed in b07d8d303dc44043f0dda420940ce246e8a94a90

facelessuser commented 3 months ago

Making a release now

toxpal commented 3 months ago

Yay, the title is back!