facelessuser / Rummage

Rummage is a GUI for grep like searches in Python
https://facelessuser.github.io/Rummage/
MIT License
75 stars 9 forks source link

Provide a way to clean backed up results #469

Open sojusnik opened 1 month ago

sojusnik commented 1 month ago

Would it be possible to add an option to do backups into a configurable global folder in addition to the existing option to save into a subfolder of the replaced file?

Maybe by allowing to provide a full path in the settings where you define the backup folder, like ~/Rummage-Backups or /tmp/Rummage? So when a full path is present, then the backups are always saved to the same global folder and not a subfolder any more?

facelessuser commented 1 month ago

Well, with a global folder, you could have issues where you could have multiple files with the same name (in different directories) overwriting each other. It gets tricky. Even if you try to preserve folder structure.

Is the problem that you find it difficult to clean up the folders or files afterwards? It's likely we could add a command to delete them all when you want to clean them up. I can understand that being an annoying problem, and a way to clean them up once you are satisfied you didn't destroy your documents might be nice.

To be honest, because most of the things I'm applying replace to are in version controlled repositories, I never enable backups as the version control systems make it easy to revert such changes.

sojusnik commented 1 month ago

Is the problem that you find it difficult to clean up the folders or files afterwards? It's likely we could add a command to delete them all when you want to clean them up. I can understand that being an annoying problem, and a way to clean them up once you are satisfied you didn't destroy your documents might be nice.

Yes, that's the main reason. So if cleaning up could be automated with the press of a button, that would do it too.

facelessuser commented 1 month ago

Yes, that's the main reason. So if cleaning up could be automated with the press of a button, that would do it too.

I can put that on my todo list then when I have some time. I imagine I would keep it fairly simple:

Anyway, I think I know roughly what I want it to look like, I just will need to carve out the time to do it.